Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Reviewed by you" filter for pull requests #22927

Merged
merged 6 commits into from
Feb 25, 2023

Conversation

brechtvl
Copy link
Contributor

@brechtvl brechtvl commented Feb 15, 2023

This includes pull requests that you approved, requested changes or commented on. Currently such pull requests are not visible in any of the filters on /pulls, while they may need further action like merging, or prodding the author or reviewers.

Especially when working with a large team on a repository it's helpful to get a full overview of pull requests that may need your attention, without having to sift through the complete list.

@brechtvl brechtvl force-pushed the blender-filter-approved-by branch from 301a687 to a461e4e Compare February 15, 2023 21:03
@brechtvl
Copy link
Contributor Author

brechtvl commented Feb 15, 2023

In #16074 a number of other filters are proposed. I think for the home page it makes sense to keep the number of filters limited, both for performance and to avoid clutter. Adding more filters to the Type menu in issue lists on the other hand does not have those problems, so I imagine more could be added there.

And so a question is, what is a good set of default filters for the home page, and why should this one be on there? For me the reason is that this makes the pulls that need my attention complete. Having pulls already listed under "created by you" categorized more finely is useful, but I'm usually quite aware of the state of my own pulls. Having pulls filtered by review state regardless of my involvement also is useful, but perhaps would work best to have only in the Type filter menu in a repository.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2023
@lunny
Copy link
Member

lunny commented Feb 17, 2023

Maybe we need a util.OptionalBool, so that we can add a new filter Rejected by you.

@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 17, 2023
@brechtvl
Copy link
Contributor Author

I'm not sure what you mean by util.OptionalBool?

An alternative here would be to instead add a filter Reviewed by you, which would include any pull requests where you approved or requested changes. On GitHub that filter also include pull requests that you commented on, which seems good.

If we do that, the filters together would include all the pull requests that you interacted with, which is the main thing I'm after. It also makes #22926 less important for me, though for issues it would still be nice to somehow see issues that I commented on somewhere.

@delvh
Copy link
Member

delvh commented Feb 18, 2023

util.OptionalBool is a type that can be true, false, or Not Present, so a ternary boolean.
That way you can differentiate between filter with "Approved by you", filter with "Not Approved by you", and do not filter by "Approved by you".
I guess that's what lunny meant.

This includes pull requests that you approved, requested changes or commented
on. Currently such pull requests are not visible in any of the filters on
/pulls, while they may need further action like merging, or prodding the
author or reviewers.

Especially when working with a large team on a repository it's helpful to get
a full overview of pull requests that may need your attention, without having
to sift through the complete list.
@brechtvl brechtvl force-pushed the blender-filter-approved-by branch from a461e4e to a7e905b Compare February 18, 2023 11:24
@brechtvl brechtvl changed the title Add "Approved by you" filter for pull requests Add "Reviewed by you" filter for pull requests Feb 18, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Feb 24, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2023
@techknowlogick
Copy link
Member

ping LG-TM bot

@techknowlogick techknowlogick merged commit 10cdcb9 into go-gitea:main Feb 25, 2023
@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 25, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 27, 2023
* giteaofficial/main:
  Revert "[skip ci] Updated translations via Crowdin" (go-gitea#23167)
  [skip ci] Updated translations via Crowdin
  Return 404 instead of 403 if user can not access the repo (go-gitea#23155)
  [skip ci] Updated licenses and gitignores
  Fix secrets overview page missing from docs sidebar (go-gitea#23143)
  Add "Reviewed by you" filter for pull requests (go-gitea#22927)
  Projects: rename Board to Column in interface and improve consistency (go-gitea#22767)
  Fix DBConsistency checks on MSSQL (go-gitea#23132)
  Add pagination for dashboard and user activity feeds (go-gitea#22937)
  Update go.mod dependencies (go-gitea#23126)
  Show empty repos in Admin Repository Management page (go-gitea#23114)
  Redirect to the commit page after applying patch (go-gitea#23056)
  Bump go.etcd.io/bbolt and blevesearch deps (go-gitea#23062)
  Fix height for sticky head on large screen on PR page (go-gitea#23111)
@brechtvl brechtvl deleted the blender-filter-approved-by branch March 11, 2023 11:29
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants