Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /dev/urandom to create random password #2298

Merged
merged 3 commits into from
Aug 13, 2017
Merged

Use /dev/urandom to create random password #2298

merged 3 commits into from
Aug 13, 2017

Conversation

leitzler
Copy link
Contributor

@leitzler leitzler commented Aug 12, 2017

Previous solution used "date +%s" to generate a random password. Since drone logs the timestamp when that command is executed, the generated password wasn't random at all.

Use /dev/urandom to get a 32 char password
Use /dev/urandom to generate 32 char password
@bkcsoft
Copy link
Member

bkcsoft commented Aug 12, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 12, 2017
@sapk
Copy link
Member

sapk commented Aug 13, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 13, 2017
@lunny lunny added this to the 1.2.0 milestone Aug 13, 2017
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 13, 2017
@lunny lunny merged commit 2282e24 into go-gitea:master Aug 13, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants