Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make issue meta dropdown support Enter, confirm before reloading #23014
Make issue meta dropdown support Enter, confirm before reloading #23014
Changes from 7 commits
8a4382b
649fa2d
8668a88
6d1c734
1bd96d3
d263120
ec0919e
afef2c4
1f94a46
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm of the opinion that it's better to just save unsubmitted data into
sessionStorage
orlocalStorage
and subsequently restore it on page load, but hooking onbeforeunload would also have been an improvement over this method because it works even when the user presses F5 for example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also proposed so (draft) as one approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before SimpleMDE/EasyMDE, there is a global
$.areYourSure
confirm (using onbeforeunload) for comment textarea. Everything was just "fine".However,
$.areYourSure
doesn't work well with SimpleMDE/EasyMDE editor, so the situation became what you see now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this
jquery-are-you-sure
module and implement it on our own to be more flexible. It also has a license issue.Ideally I would this to also not use
window.confirm
, but a actual styled confirmation dialog (maybe not fomantic).