-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger sync webhooks on UI commit #2302
Conversation
|
||
log.Trace("TriggerTask '%s/%s' by %s", repo.Name, branch, pusher.Name) | ||
|
||
go models.HookQueue.Add(repo.ID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is actually removed (as opposed to simply being moved to models/update.go
), since the repo ID is already added to HookQueue
by CommitRepoAction(..)
In fact, there are still many places to call |
@lunny Good point, I've updated |
LGTM |
LGTM |
Fixes #2295.
Ensure that
AddTestPullRequestTask(..)
called during a UI commit. For normally-pushed commits,AddTestPullRequestTask(..)
is called by thepost-receive
webhook, but the webhook does not run* for UI commits.(*It technically runs, but immediately quits because
$SSH_ORIGINAL_COMMAND
is not set)