Nest metadata in refactoring docs #23087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
type/docs
|
Thank you. I just had some thoughts about that the refactoring guideline should be clarified about:
For example: Now 1.19 is releasing, if a refactoring PR is big, it should be done after 1.19.1, this will make bug fixes for 1.19.1 could be backported easily. Because only after 1.19.0 released, there are enough users to use and report bugs. If a big refactoring PR is merged into 1.20-dev before 1.19.1, then the backporting of bug fixes for 1.19.1 would cause many conflicts. |
GiteaBot
added
the
lgtm/need 2
wolfogre
approved these changes
Feb 23, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 23, 2023
GiteaBot
added
lgtm/done
yardenshoham
pushed a commit
to yardenshoham/gitea
that referenced
this pull request
Feb 23, 2023
Whitespace was missing from refactoring docs metadata. backport label applied so it is included in versioned docs.
techknowlogick
added a commit
that referenced
this pull request
Feb 23, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 24, 2023
* giteaofficial/main: Make issue meta dropdown support Enter, confirm before reloading (go-gitea#23014) Fix SyncOnCommit always return false in API of push_mirrors (go-gitea#23088) Fix commit name in Apply Patch page (go-gitea#23086) Add wrapper to author to avoid long name ui problem (go-gitea#23030) Avoid Hugo from adding quote to actions url (go-gitea#23097) Remove all package data after tests (go-gitea#22984) Change style to improve whitespaces trimming inside inline markdown code (go-gitea#23093) Nest metadata in refactoring docs (go-gitea#23087) # Conflicts: # templates/repo/issue/view_content/context_menu.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespace was missing from refactoring docs metadata.
backport label applied so it is included in versioned docs.