-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless comment in #23114 #23173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Feb 27, 2023
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Feb 27, 2023
wolfogre
approved these changes
Feb 27, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 27, 2023
delvh
added
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Feb 27, 2023
yardenshoham
approved these changes
Feb 27, 2023
yardenshoham
added
the
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
label
Feb 27, 2023
KN4CK3R
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Feb 27, 2023
yardenshoham
pushed a commit
to yardenshoham/gitea
that referenced
this pull request
Feb 27, 2023
The `isAdmin` param is no longer used so the comment should be removed. https://github.com/go-gitea/gitea/blob/d27d36f2f4dd389050e613967ad2a5d02d250acc/routers/web/explore/repo.go#L36-L37
lunny
pushed a commit
that referenced
this pull request
Feb 27, 2023
Backport #23173 The `isAdmin` param is no longer used so the comment should be removed. https://github.com/go-gitea/gitea/blob/d27d36f2f4dd389050e613967ad2a5d02d250acc/routers/web/explore/repo.go#L36-L37 Co-authored-by: Zettat123 <zettat123@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 28, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Change button text for commenting and closing an issue at the same time (go-gitea#23135) Don't run unnecessary steps when only docs changed (go-gitea#23103) Add word-break to sidebar-item-link (go-gitea#23146) Speed up HasUserStopwatch & GetActiveStopwatch (go-gitea#23051) Add InsecureSkipVerify to Minio Client for Storage (go-gitea#23166) Fix Fomantic UI's `touchstart` fastclick, always use `click` for click events (go-gitea#23065) Remove useless comment in go-gitea#23114 (go-gitea#23173) Remove xin-u from maintainers (go-gitea#23170)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isAdmin
param is no longer used so the comment should be removed.gitea/routers/web/explore/repo.go
Lines 36 to 37 in d27d36f