Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct selector to hide the checkmark of selected labels on clear (#23224) #23226

Merged

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Mar 1, 2023

Backport #23224

Regression of #10107 (https://github.com/go-gitea/gitea/pull/10107/files#diff-a15e36f2f9c13339f7fdd38bc2887db2ff2945cb8434464318ab9105fcc846bdR460)

Fix #22222

Before: the "clear" action couldn't remove these check marks.

image

After: the "clear" action can remove these check marks.

image

@GiteaBot GiteaBot added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Mar 1, 2023
@techknowlogick techknowlogick added this to the 1.18.6 milestone Mar 1, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 1, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2023
@techknowlogick techknowlogick merged commit 0c212b3 into go-gitea:release/v1.18 Mar 1, 2023
@techknowlogick techknowlogick deleted the backport-23224-v1.18 branch March 1, 2023 20:59
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants