Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async await to fix empty quote reply at first time (#23168) #23256

Merged
merged 2 commits into from
Mar 2, 2023

Commits on Mar 2, 2023

  1. Use async await to fix empty quote reply at first time (go-gitea#23168)

    The reason why quote reply is empty is when quote reply is clicked, it
    triggers the click function on `.comment-form-reply` button, and when
    the first time this function is triggered, easyMDE for the reply has not
    yet initialized, so that click handler of `.quote-reply` button in
    `repo-legacy.js` got an `undefined` as easyMDE, and the following lines
    which put quoted reply into the easyMDE is not executed.
    The workaround in this PR is to pass the replied content to
    '.comment-form-reply' button if easyMDE is not yet initialized (quote
    reply first clicked) and put the replied content into it the after
    easyMDE is created.
    Now quote reply on first click:
    
    
    https://user-images.githubusercontent.com/17645053/221452823-fc699d50-1649-4af1-952e-f04fc8d2978e.mov
    
    <br />
    
    
    Update:
    The above change is not appropriate as stated in the
    [comment](go-gitea#23168 (comment))
    Use await instead
    
    Close go-gitea#22075.
    Close go-gitea#23247.
    HesterG authored and GiteaBot committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    bdbfb3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec3a1e6 View commit details
    Browse the repository at this point in the history