-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display for context menu #23342
Fix display for context menu #23342
Conversation
@@ -1,6 +1,7 @@ | |||
.gt-df { display: flex !important; } | |||
.gt-di { display: inline !important; } | |||
.gt-dif { display: inline-flex !important; } | |||
.gt-db { display: block !important; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this proposal:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think HesterG's answer is definitely yes because she already gave your proposal a thumbs up. 😄
But maybe it's a good idea to keep the old style before refactoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this proposal:
I pretty agreed with this comment, but i am note sure if we could partially introduce tailwind, like only introduce widely used css like we now have inside helper.less
I think the root problem is |
See Fix incorrect display for comment context menu #23343 Actually I had a TODO there "in the future there could be a special CSS class for it". that TODO would help similar problems in the future. |
Closed as #23343 fixed the root problem |
This PR is to fix the wrong display for context menu. The reason this occurs is because
display
was overwitten by style of fomantic component, specifically the following ruleBefore:
After: