Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent conflicting TOTP accounts by adding AppURL to issuer parameter #2335

Merged
merged 1 commit into from
Aug 19, 2017

Conversation

daviian
Copy link
Member

@daviian daviian commented Aug 18, 2017

Targets #2332

Added AppURL without trailing slash to issuer parameter in TOTP QR Code generation.

… conflicting accounts on multiple gitea installations

Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Aug 18, 2017
@lafriks lafriks added this to the 1.x.x milestone Aug 18, 2017
@lafriks
Copy link
Member

lafriks commented Aug 18, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 18, 2017
@lunny lunny modified the milestones: 1.2.0, 1.x.x Aug 19, 2017
@lunny
Copy link
Member

lunny commented Aug 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 19, 2017
@lunny lunny merged commit 5707ad3 into go-gitea:master Aug 19, 2017
@daviian daviian deleted the totp-conflicting-accounts branch August 19, 2017 08:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants