Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recognize text files as audio (#23355) #23367

Closed

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Mar 8, 2023

Backport #23355

Close #17108

This PR uses a trick (removing the ID3 tag) to detect the content again to to see whether the content is text type.

Close go-gitea#17108

This PR uses a trick (removing the ID3 tag) to detect the content again
to to see whether the content is text type.

---------

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot added this to the 1.18.6 milestone Mar 8, 2023
@lunny
Copy link
Member

lunny commented Mar 8, 2023

CI failure is related @wxiaoguang

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2023
@wxiaoguang
Copy link
Contributor

I think a import bytes is missing here. The bytes package was added by another backport #23312 / #23358 before.

Maybe we do not need to backport to 1.18?

@techknowlogick techknowlogick deleted the backport-23355-v1.18 branch March 8, 2023 05:32
@lunny lunny removed this from the 1.18.6 milestone Mar 8, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants