Skip DB tests duplicate runs on push to branches

[techknowlogick]

This skips all testing-* pipelines on push to main or release/* branches. This decreases the total build time on those, as in theory they should already be run for PRs before merging.

Fixes #22011

[jolheiser]

Ah thanks, I was also looking at something for this.

One thing, we may need the mysql pipeline to run still, as that includes our coverage report.

[jolheiser]

This also partially covers #22011, though this doesn't cover tags afaict

[techknowlogick]

This also partially covers #22011, though this doesn't cover tags afaict

just update to skip tags.

One thing, we may need the mysql pipeline to run still, as that includes our coverage report.

I think we need to reflect on our coverage reports, and if they are in fact used/reviewed.

[jolheiser]

With your latest changes, is it simpler to just remove push from the events rather than exclude?
That was my approach in my branch.

Further, some of the release pipelines depend on these test pipelines, if they don't run does that need to change? I believe I just changed them to depend on compliance instead. (Hadn't checked if that's correct, though)

[techknowlogick]

With your latest changes, is it simpler to just remove push from the events rather than exclude? That was my approach in my branch.

Yes, it certainly would (you can see it in the testing-e2e pipeline), I went for an exclude if for some reason we need to push a branch that isn't main or release/* and want to run things. Definitely not the cleanest approach, and possibly am attempting to optimizing for something that may never happen. Happy to change if you (or others) have strong feelings about it.

Further, some of the release pipelines depend on these test pipelines, if they don't run does that need to change? I believe I just changed them to depend on compliance instead. (Hadn't checked if that's correct, though)

So the fun (in a good way) thing is that drone will adjust the dag to accommodate for skipped pipelines (see: https://gitea.com/gitea/drone-test/src/branch/main/.drone.yml for an example of how this plays out in practice)

[techknowlogick]

LOLOL, yup. This doesn't work. I'll need to change it to the way you suggested @jolheiser

[jolheiser]

I do think I prefer changing to removing push instead, only because it will be clearer in a year when I look again and think "what is this doing???" 😂

Just my opinion, though, I'm fine with approving either once we get it passing. 🙂

[techknowlogick]

@jolheiser my "LLOLOL" comment above was checking out the run, and seeing that drone uses the "branch" condition in the evaluation for PRs, so if I say "skip main" then it'll skip that pipeline for PRs attempting to merge into main. So the way you suggested is likely the only way to go. I've updated to just remove push