Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add creation time in tag list page #23693

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Add creation time in tag list page #23693

merged 4 commits into from
Mar 28, 2023

Conversation

balki
Copy link
Contributor

@balki balki commented Mar 24, 2023

Fixes #21699

@sillyguodong sillyguodong added the topic/ui Change the appearance of the Gitea UI label Mar 25, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 25, 2023
@balki balki requested a review from sillyguodong March 25, 2023 11:08
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023 •
edited
Loading

Codecov Report

Merging #23693 (3423675) into main (f521e88) will increase coverage by 0.02%.
The diff coverage is 41.40%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23693      +/-   ##
==========================================
+ Coverage   47.14%   47.16%   +0.02%     
==========================================
  Files        1149     1155       +6     
  Lines      151446   152396     +950     
==========================================
+ Hits        71397    71884     +487     
- Misses      71611    72029     +418     
- Partials     8438     8483      +45
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.64% <0.00%> (-0.08%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
models/user/search.go 77.50% <0.00%> (-6.29%) ⬇️
modules/actions/workflows.go 0.00% <0.00%> (ø)
modules/context/context.go 64.54% <0.00%> (-3.53%) ⬇️
modules/doctor/storage.go 30.65% <0.00%> (-1.29%) ⬇️
modules/setting/git.go 45.45% <ø> (ø)
... and 37 more

... and 41 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 26, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 26, 2023
silverwind
silverwind requested changes Mar 26, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment above

@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2023
@silverwind
Copy link
Member

silverwind commented Mar 27, 2023 •
edited
Loading

Pushed a fix that removed the unnecessary classes. What eluded me is that TimeSinceUnix already renders a <span>, so not time class needed, but wrapper span is still needed for margin (could move margin to CSS, but I'd prefer to keep this PR simple).

image

This is how it looks now:

image

@silverwind silverwind added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Mar 27, 2023
@silverwind
Copy link
Member

silverwind commented Mar 27, 2023 •
edited
Loading

Added backport label as it's a nice litte enhancement with no risks.

@silverwind silverwind added the type/enhancement An improvement of existing functionality label Mar 27, 2023
@balki
Copy link
Contributor Author

balki commented Mar 28, 2023

@silverwind I don't have merge permissions. Please merge if everything looks good. Let me know if I have to rebase/merge from master.

@silverwind
Copy link
Member

Mergers will merge it when they get around to it.

@jolheiser jolheiser enabled auto-merge (squash) March 28, 2023 16:09
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2023
@jolheiser jolheiser merged commit 85e8c83 into go-gitea:main Mar 28, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2023
@GiteaBot GiteaBot mentioned this pull request Mar 28, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 28, 2023
@balki @GiteaBot
Add creation time in tag list page (go-gitea#23693)
be99271 
Fixes go-gitea#21699
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Mar 28, 2023
techknowlogick pushed a commit that referenced this pull request Mar 28, 2023
@GiteaBot @balki
Add creation time in tag list page (#23693) (#23773)
d977e7e 
Backport #23693 by @balki

Fixes #21699

Co-authored-by: Balki <189196+balki@users.noreply.github.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 29, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
58ed503 
* upstream/main:
  Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (go-gitea#23687)
  Add CSS rules for basic colored labels (go-gitea#23774)
  Add meilisearch support (go-gitea#23136)
  Add missing translation for `actions.runners.reset_registration_token_success` (go-gitea#23732)
  [skip ci] Updated translations via Crowdin
  Implement Issue Config (go-gitea#20956)
  Set repository link based on the url in package.json for npm packages (go-gitea#20379)
  Add API to manage issue dependencies (go-gitea#17935)
  Add creation time in tag list page (go-gitea#23693)
  Make minio package support legacy MD5 checksum (go-gitea#23768)
  Yarden Shoham has a new email address (go-gitea#23767)
  fix br display for packages curls (go-gitea#23737)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@sillyguodong sillyguodong sillyguodong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Show dates for tags
8 participants
@balki @codecov-commenter @silverwind @wxiaoguang @sillyguodong @lunny @GiteaBot @jolheiser