Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict #23766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
fix-explore-repo
branch
from
a06bd57 to
c666846
Compare
lunny
approved these changes
Mar 28, 2023
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #23766 +/- ##
==========================================
- Coverage 47.14% 47.14% -0.01%
==========================================
Files 1149 1155 +6
Lines 151446 152502 +1056
==========================================
+ Hits 71397 71893 +496
- Misses 71611 72116 +505
- Partials 8438 8493 +55
... and 51 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
silverwind
approved these changes
Mar 28, 2023
silverwind
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
🎺 🤖 |
jolheiser
removed
the
reviewed/wait-merge
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Mar 29, 2023
…re strict (go-gitea#23766) Follow go-gitea#21962 After I eat my own dogfood, I would say that ONLY_SHOW_RELEVANT_REPOS=false is necessary for many private/enterprise instances, because many private repositories do not have "description/topic", users just want to search by their names. This PR also adds `PageIsExploreRepositories` check, to make code more strict, because the `search` template is shared for different purpose. And during the test, I found a bug that the "Search" button didn't respect the "relevant" parameter, so this PR fixes the bug by the way together. I think this PR needs to be backported. # Conflicts: # templates/explore/repo_search.tmpl
jolheiser
pushed a commit
that referenced
this pull request
Mar 30, 2023
…re strict (#23766) (#23791) Follow #21962 After I eat my own dogfood, I would say that ONLY_SHOW_RELEVANT_REPOS=false is necessary for many private/enterprise instances, because many private repositories do not have "description/topic", users just want to search by their names. This PR also adds `PageIsExploreRepositories` check, to make code more strict, because the `search` template is shared for different purpose. And during the test, I found a bug that the "Search" button didn't respect the "relevant" parameter, so this PR fixes the bug by the way together.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Fix dropdown direction behavior (go-gitea#23806) Fix incorrect/Improve error handle in edit user page (go-gitea#23805) Fix "Updating branch by merge" bug in "update_branch_by_merge.tmpl" (go-gitea#23790) Fix incorrect visibility dropdown list in add/edit user page (go-gitea#23804) Convert issue list checkboxes to native (go-gitea#23596) Fix checks for `needs` in Actions (go-gitea#23789) Diff improvements (go-gitea#23553) [Patch] Fix closed PR also triggers Webhooks and actions (go-gitea#23782) Improve backport-locales.go (go-gitea#23807) [skip ci] Updated translations via Crowdin Refactor commit status for Actions jobs (go-gitea#23786) Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict (go-gitea#23766) Don't apply the group filter when listing LDAP group membership if it is empty (go-gitea#23745)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #21962
After I eat my own dogfood, I would say that ONLY_SHOW_RELEVANT_REPOS=false is necessary for many private/enterprise instances, because many private repositories do not have "description/topic", users just want to search by their names.
This PR also adds
PageIsExploreRepositoriescheck, to make code more strict, because thesearchtemplate is shared for different purpose.And during the test, I found a bug that the "Search" button didn't respect the "relevant" parameter, so this PR fixes the bug by the way together.
I think this PR needs to be backported.
Update: backport done. For 1.19 stable release, you can use the nightly build from https://dl.gitea.com/gitea/1.19/ or docker
gitea:1.19-dev, everything is back.