Fix review box viewport overflow issue #23800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
the
outdated/backport/v1.19
silverwind
force-pushed
the
overflow-review
branch
from
0784f17 to
6027774
Compare
silverwind
changed the title
|
No one else annoyed by this bug? 😉 |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Mar 31, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Apr 3, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
🎺 🤖 |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 3, 2023
Fix regression that came likely from go-gitea#23271: Long lines of text currently cause the review box's CodeMirror element to resize which apparently is not recognized by [popper's resize detection](https://popper.js.org/docs/v2/modifiers/event-listeners/) and which causes the element to go partially out of viewport until a reflow happens:  Fix this by setting the element to a static width derived from viewport width and remove the previously clumsy media queries.
jolheiser
removed
the
reviewed/wait-merge
jolheiser
pushed a commit
that referenced
this pull request
Apr 3, 2023
Backport #23800 by @silverwind Fix regression that came likely from #23271: Long lines of text currently cause the review box's CodeMirror element to resize which apparently is not recognized by [popper's resize detection](https://popper.js.org/docs/v2/modifiers/event-listeners/) and which causes the element to go partially out of viewport until a reflow happens:  Fix this by setting the element to a static width derived from viewport width and remove the previously clumsy media queries. Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 4, 2023
* upstream/main: Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823) Remove fomantic ".link" selector and styles (go-gitea#23888) [skip ci] Updated translations via Crowdin Fix `cases.Title` crash for concurrency (go-gitea#23885) Disable editing tags (go-gitea#23883) Fix user profile description rendering (go-gitea#23882) Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861) Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839) Fix review box viewport overflow issue (go-gitea#23800) Fix owner team access mode value in team_unit table (go-gitea#23675) Fix submit button won't refresh in New Repository Fork page (go-gitea#22994) Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876) Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736) Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734) Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733) Try to catch more broken translations (go-gitea#23867)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression that came likely from #23271:
Long lines of text currently cause the review box's CodeMirror element to resize which apparently is not recognized by popper's resize detection and which causes the element to go partially out of viewport until a reflow happens:
Fix this by setting the element to a static width derived from viewport width and remove the previously clumsy media queries.