Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental overwriting of LDAP team memberships #24050

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Fix accidental overwriting of LDAP team memberships #24050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb0a62
fix
sillyguodong Apr 11, 2023
e563208
Merge branch 'main' into bugfix/resolve_mapped_memberships
delvh Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/auth/source/source_group_sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ func resolveMappedMemberships(sourceUserGroups container.Set[string], sourceGrou
isUserInGroup := sourceUserGroups.Contains(group)
if isUserInGroup {
for org, teams := range memberships {
membershipsToAdd[org] = teams
membershipsToAdd[org] = append(membershipsToAdd[org], teams...)
}
} else {
for org, teams := range memberships {
membershipsToRemove[org] = teams
membershipsToRemove[org] = append(membershipsToRemove[org], teams...)
}
}
}
Expand Down