Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix route handler order #2409

Merged
merged 2 commits into from
Aug 29, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

Fix out-of-order handlers

@bkcsoft
Copy link
Member

bkcsoft commented Aug 28, 2017

LGTM

/cc @lunny

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 28, 2017
@lafriks
Copy link
Member

lafriks commented Aug 28, 2017

I think it should be changed also in other places then:
m.Get("/archive/*"... and m.Get("/compare/:...

@lafriks
Copy link
Member

lafriks commented Aug 29, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2017
@lunny lunny added this to the 1.3.0 milestone Aug 29, 2017
@lunny lunny added the type/bug label Aug 29, 2017
@lunny lunny merged commit 491f0eb into go-gitea:master Aug 29, 2017
@ethantkoenig ethantkoenig deleted the fix/handler_order branch September 10, 2017 00:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants