Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code search with meilisearch #24149

Closed

Conversation

techknowlogick
Copy link
Member

WIP

@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 16, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 16, 2023
@techknowlogick techknowlogick requested a review from pat-s April 16, 2023 02:13
@silverwind
Copy link
Member

silverwind commented Apr 17, 2023

In case the file sort order is part of the search engine code, could stable sort (#24170) be implemented here? 😉

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2023
@pat-s
Copy link
Member

pat-s commented May 1, 2023

@techknowlogick I tested this PR. While I can start Gitea without errors and set meilisearch as the code indexer, I always end up with No source code matching your search term found. for every search. Even just basic ones, e.g. searching for get or similar (fuzzy mode).

I can see that some indexing is happening in the connected meilisearch instance.

Let me know how I can dig deeper to provide some meaningful log insights or similar.

@poVoq
Copy link

poVoq commented May 25, 2023

@techknowlogick I tested this PR. While I can start Gitea without errors and set meilisearch as the code indexer, I always end up with No source code matching your search term found. for every search. Even just basic ones, e.g. searching for get or similar (fuzzy mode).

I can see that some indexing is happening in the connected meilisearch instance.

Let me know how I can dig deeper to provide some meaningful log insights or similar.

This might also be a general problem in the Gitea repo search code. I have been trying to get the Elasticsearch support working with Zincsearch and what you describe is exactly the behaviour I see with Zincsearch as well.

@techknowlogick
Copy link
Member Author

@poVoq I replied to @pat-s elsewhere, but I'll repost here so that anyone else tracking can also see. The reason no search results are coming up is that the code for searching in meilisesrxh doesn't exist yet, only indexing. That's what the WIP part of this PR is.

Your issue with zincsearch may be something else, and you may wish to open a an issue about that to track.

@delvh delvh removed this from the 1.20.0 milestone Jun 4, 2023
@Bisstocuz
Copy link

@techknowlogick I tested this PR. While I can start Gitea without errors and set meilisearch as the code indexer, I always end up with No source code matching your search term found. for every search. Even just basic ones, e.g. searching for get or similar (fuzzy mode).
I can see that some indexing is happening in the connected meilisearch instance.
Let me know how I can dig deeper to provide some meaningful log insights or similar.

This might also be a general problem in the Gitea repo search code. I have been trying to get the Elasticsearch support working with Zincsearch and what you describe is exactly the behaviour I see with Zincsearch as well.

Maybe here is a related issue zincsearch/zincsearch#538

@poVoq
Copy link

poVoq commented Jul 5, 2023

@techknowlogick no plans to finish this? Really a pity as otherwise only Elastic/Opensearch seem to work and those are really not great.

@lunny
Copy link
Member

lunny commented Jul 5, 2023

Because indexer will have a big refactor, so I think this PR will be affected. Maybe another PR could be created after the refactor finished. ref: #25174

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants