-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code search with meilisearch #24149
code search with meilisearch #24149
Conversation
In case the file sort order is part of the search engine code, could stable sort (#24170) be implemented here? 😉 |
@techknowlogick I tested this PR. While I can start Gitea without errors and set I can see that some indexing is happening in the connected meilisearch instance. Let me know how I can dig deeper to provide some meaningful log insights or similar. |
This might also be a general problem in the Gitea repo search code. I have been trying to get the Elasticsearch support working with Zincsearch and what you describe is exactly the behaviour I see with Zincsearch as well. |
@poVoq I replied to @pat-s elsewhere, but I'll repost here so that anyone else tracking can also see. The reason no search results are coming up is that the code for searching in meilisesrxh doesn't exist yet, only indexing. That's what the WIP part of this PR is. Your issue with zincsearch may be something else, and you may wish to open a an issue about that to track. |
Maybe here is a related issue zincsearch/zincsearch#538 |
@techknowlogick no plans to finish this? Really a pity as otherwise only Elastic/Opensearch seem to work and those are really not great. |
Because indexer will have a big refactor, so I think this PR will be affected. Maybe another PR could be created after the refactor finished. ref: #25174 |
WIP