Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default show closed actions list if all actions was closed #24234

Merged
merged 8 commits into from
Apr 25, 2023
Merged

default show closed actions list if all actions was closed #24234

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
09aaad6
default show closed actions list if all actions was closed
a1012112796 Apr 20, 2023
03a4041
Merge branch 'main' into zzc/dev/actions_list_ui
a1012112796 Apr 21, 2023
2c848e2
Merge remote-tracking branch 'origin/main' into zzc/dev/actions_list_ui
a1012112796 Apr 22, 2023
bf8a986
simpfy logic
a1012112796 Apr 22, 2023
67b0d57
Merge remote-tracking branch 'origin/main' into zzc/dev/actions_list_ui
a1012112796 Apr 24, 2023
e4f1f5d
fix logic
a1012112796 Apr 24, 2023
70fee40
Merge branch 'main' into zzc/dev/actions_list_ui
silverwind Apr 24, 2023
3e5a4e4
Merge branch 'main' into zzc/dev/actions_list_ui
techknowlogick Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion routers/web/repo/actions/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,18 @@ func List(ctx *context.Context) {
ctx.Data["NumClosedActionRuns"] = numClosedRuns

opts.IsClosed = util.OptionalBoolNone
if ctx.FormString("state") == "closed" {
isShowClosed := ctx.FormString("state") == "closed"
if len(ctx.FormString("state")) == 0 && numOpenRuns == 0 && numClosedRuns != 0 {
isShowClosed = true
}

if isShowClosed {
opts.IsClosed = util.OptionalBoolTrue
ctx.Data["IsShowClosed"] = true
} else {
opts.IsClosed = util.OptionalBoolFalse
}

runs, total, err := actions_model.FindRuns(ctx, opts)
if err != nil {
ctx.Error(http.StatusInternalServerError, err.Error())
Expand Down