Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING #24270

Merged
merged 3 commits into from
Apr 22, 2023
Merged

Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING #24270

merged 3 commits into from
Apr 22, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 22, 2023 •
edited
Loading

The SHOW_FOOTER_BRANDING came from year 2015, and it seems nobody ever uses it. It only shows an GitHub icon which seems unrelated to Gitea, it doesn't do what document says. So, remove it.

⚠️ Breaking

Users can now remove the key [other].SHOW_FOOTER_BRANDING from their app.ini.

@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 22, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2023
silverwind
silverwind approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 22, 2023
@silverwind silverwind added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Apr 22, 2023
@delvh delvh added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 22, 2023
@wxiaoguang
Copy link
Contributor Author

Additionally, if anyone uses custom templates containing the function .ShowFooterBranding, the templates need to be recompiled.

I think no need to mention this. Our Golang template can bear the missing fields. {{.NoSuch}} won't cause any problem.

So, I think it could just keep the description simple.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 22, 2023
@delvh delvh changed the title Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING Refactor setting.Other and remove unused SHOW_FOOTER_BRANDING Apr 22, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 22, 2023
@silverwind silverwind enabled auto-merge (squash) April 22, 2023 21:48
@silverwind silverwind merged commit d44e156 into go-gitea:main Apr 22, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 22, 2023
@wxiaoguang wxiaoguang deleted the refactor-setting-other branch April 23, 2023 02:34
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @silverwind @delvh @GiteaBot