Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags list for repos whose release setting is disabled (#23465) #24369

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

Zettat123
Copy link
Contributor

Backport #23465

Close #23427

Co-Author: @wxiaoguang

If a repo's release setting is enabled, the logic has't changed. Clicking the "Tags" button will jump to /{user}/{repo}/tags and templates/repo/release/list.tmpl template will be used.

If the release setting is disabled, clicking the "Tags" button will still jump to /{user}/{repo}/tags but a new template templates/repo/tag/list.tmpl will be used.

Since both templates above need to render the tags list, I moved the tags list to a shared template located in templates/repo/tag/table.tmpl.

Zettat123 and others added 2 commits April 27, 2023 10:51
…3465)

Close go-gitea#23427

Co-Author: @wxiaoguang

If a repo's release setting is enabled, the logic has't changed.
Clicking the "Tags" button will jump to `/{user}/{repo}/tags` and
`templates/repo/release/list.tmpl` template will be used.

<img
src="https://user-images.githubusercontent.com/15528715/224939362-bd8974fd-08b0-4f79-a114-3389d15847ca.png"
width="600px" />

If the release setting is disabled, clicking the "Tags" button will
still jump to `/{user}/{repo}/tags` but a new template
`templates/repo/tag/list.tmpl` will be used.

<img
src="https://user-images.githubusercontent.com/15528715/233834564-74741e49-f4e9-47c8-ac12-e306642798dc.png"
width="600px" />

Since both templates above need to render the tags list, I moved the
tags list to a shared template located in
`templates/repo/tag/table.tmpl`.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot added this to the 1.19.2 milestone Apr 27, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 27, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2023
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2023
@lunny lunny merged commit e301e26 into go-gitea:release/v1.19 Apr 27, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2023
@lunny lunny mentioned this pull request Apr 27, 2023
@wxiaoguang wxiaoguang deleted the backport/23465_to_v1.19 branch July 5, 2023 13:50
techknowlogick pushed a commit that referenced this pull request Jul 5, 2023
Fix #25705

Regression of #24369

There is no problem in 1.20 because there is #24459
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jul 12, 2023
Fix go-gitea#25705

Regression of go-gitea#24369

There is no problem in 1.20 because there is go-gitea#24459

(cherry picked from commit 67d16c6)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
@GiteaBot
Copy link
Collaborator

We lock pull requests 3 months after they were closed. If there's any need for further discussion, please open a new issue. 🍵

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants