Fix test delivery button in repo webhook settings page #24478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wxiaoguang
approved these changes
May 2, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 2, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
delvh
approved these changes
May 2, 2023
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 4, 2023
* upstream/main: (65 commits) Changelog for 1.19.3 (go-gitea#24495) (go-gitea#24506) Use Actions for DB & E2E tests (go-gitea#24494) Fix intermittent CI failure in EmptyQueue (go-gitea#23753) Prevent a user with a different email from accepting the team invite (go-gitea#24491) Fix incorrect webhook time and use relative-time to display it (go-gitea#24477) Make Issue/PR/projects more compact, misc CSS tweaks (go-gitea#24459) Implement Cargo HTTP index (go-gitea#24452) Clean up polluted styles and remove dead CSS code (go-gitea#24497) Improve pull request merge box when pull request merged and branch deleted. (go-gitea#24397) Fix EasyMDE toolbar (go-gitea#24489) Enhance stylelint rule config, remove dead CSS (go-gitea#24472) Fix api error message if fork exists (go-gitea#24487) Add ntlm authentication support for mail (go-gitea#23811) Fix test delivery button in repo webhook settings page (go-gitea#24478) Add Debian package registry (go-gitea#24426) Enable whitespace rendering on selection in Monaco (go-gitea#24444) Replace `N/A` with `-` everywhere (go-gitea#24474) Fix invite display (go-gitea#24447) [skip ci] Updated translations via Crowdin replace PR docker dry run in drone with Actions (go-gitea#24475) ... # Conflicts: # templates/base/footer_content.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by https://github.com/go-gitea/gitea/pull/24246/files#diff-2bfe41d93dbb409583a4f945902e46bb513f60f1c9301649c1689200c4f1466eR1
Class
newwas removed in #24246, but in functioninitCompWebHookEditor, it will check.new.webhook.So in repo webhook settings page,
initCompWebHookEditorwill init nothing, and no response after click the test delivery button.gitea/web_src/js/features/comp/WebHookEditor.js
Lines 6 to 9 in da65b7a