Change add_on translation to added_on and include placeholder for the date
#24562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
approved these changes
May 6, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
May 6, 2023
GiteaBot
added
lgtm/done
Co-authored-by: delvh <dev.lh@web.de>
yardenshoham
added
the
reviewed/wait-merge
lunny
pushed a commit
that referenced
this pull request
May 6, 2023
…aceholder for the date (#24563) - Similar to #24550 - Similar to #24562 The correct thing to do is to translate the entire phrase into a single string. The previous translation assumed all languages have a space between the "valid until" and the date (and that "valid until" comes before the date). Signed-off-by: Yarden Shoham <git@yardenshoham.com>
|
@yardenshoham please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
|
I did, thanks bot |
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 8, 2023
* upstream/main: Fix broken link in tests/e2e/README (go-gitea#24576) [skip ci] Updated licenses and gitignores Add goto issue id function (go-gitea#24479) Improve decryption failure message (go-gitea#24573) Simplify template helper functions (go-gitea#24570) Makefile: Use portable !, not GNUish -not, with find(1). (go-gitea#24565) Add org visibility label to non-organization's dashboard (go-gitea#24558) Sort users and orgs on explore by recency by default (go-gitea#24279) Change `add_on` translation to `added_on` and include placeholder for the date (go-gitea#24562) Change `valid_until` translation to `valid_until_date` and include placeholder for the date (go-gitea#24563) Fix docs failing the build on `main` (go-gitea#24561) Improve wiki user title test (go-gitea#24559) Fix incorrect user visibility (go-gitea#24557) Change `join_on` translation to `joined_on` and include placeholder for the date (go-gitea#24550) Require at least one unit to be enabled (go-gitea#24189) Fix broken `README` link (go-gitea#24546) Check latest version on CI (go-gitea#24556)
silverwind
pushed a commit
that referenced
this pull request
May 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
join_ontranslation tojoined_onand include placeholder for the date #24550The correct thing to do is to translate the entire phrase into a single string. The previous translation assumed all languages have a space between the "added on" and the date (and that "added on" comes before the date).
Some languages, like Hebrew, have no space between the "added on" and the date. For example:
added_on=נוסף ב-%s("added" becomes נוסף, "on" is ב and when paired with a date we use a dash to connect ב with the date)