Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2470 #2477

Merged
merged 3 commits into from
Sep 10, 2017
Merged

Fix #2470 #2477

merged 3 commits into from
Sep 10, 2017

Conversation

Albert221
Copy link
Contributor

It fixes #2470. I've used flexbox to do that which has the same (or better) browser compatibility as Semantic UI. It looks like this:

image
image

The only needed thing is to compile LESS to CSS which I couldn't do because I couldn't find any instructions to it. Maybe you should provide them?

@Albert221
Copy link
Contributor Author

Albert221 commented Sep 9, 2017 •
edited
Loading

CSS added.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 9, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 9, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 10, 2017
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Sep 10, 2017
@lafriks
Copy link
Member

lafriks commented Sep 10, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2017
@lafriks
Copy link
Member

lafriks commented Sep 10, 2017

Please rebase your changes on master

@bkcsoft
Copy link
Member

bkcsoft commented Sep 10, 2017

LGTM

@bkcsoft
Copy link
Member

bkcsoft commented Sep 10, 2017

Test failures seems unrelated?

@bkcsoft bkcsoft merged commit 250f123 into go-gitea:master Sep 10, 2017
@Morlinest Morlinest mentioned this pull request Sep 13, 2017
Closed
1 task
@Albert221 Albert221 deleted the view-file-fix branch January 29, 2018 14:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

UI bug - View File pushed out
6 participants
@Albert221 @ethantkoenig @lafriks @bkcsoft @lunny @tboerger