Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug in Explore when Repo has no Owner #24873

Closed
wants to merge 1 commit into from

Conversation

JakobDev
Copy link
Contributor

Fixes #24857

Do be clear, I don't know how this could happen. It should normally not possible to Delete a User and has his Repos left. I needed to change the Owner ID in the Database to test this Code. But I think it's nice to have a Fallback in case something goes wrong like in the reported Bug.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2023
@lunny
Copy link
Member

lunny commented May 23, 2023

I'm against this change. per #24857 (comment)

@6543
Copy link
Member

6543 commented Oct 19, 2023

-> #27290

@6543 6543 closed this Oct 19, 2023
6543 added a commit that referenced this pull request Oct 19, 2023
@JakobDev JakobDev deleted the ghostrepo branch October 19, 2023 13:22
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository owner can be nil if deleted and that breaks the listing of repositories.
4 participants