Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions Artifacts support uploading multiple files and directories #24874

Merged
merged 14 commits into from
Jul 21, 2023
Merged

Actions Artifacts support uploading multiple files and directories #24874

merged 14 commits into from
Jul 21, 2023

Conversation

fuxiaohei
Copy link
Contributor

@fuxiaohei fuxiaohei commented May 23, 2023 •
edited
Loading

current actions artifacts implementation only support single file artifact. To support multiple files uploading, it needs:

  • save each file to each db record with same run-id, same artifact-name and proper artifact-path
  • need change artifact uploading url without artifact-id, multiple files creates multiple artifact-ids
  • support path in download-artifact action. artifact should download to {path}/{artifact-path}.
  • in repo action view, it provides zip download link in artifacts list in summary page, no matter this artifact contains single or multiple files.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2023
@fuxiaohei fuxiaohei force-pushed the feat/artifact-upload-directories branch from c5b7314 to 3f5ce8c Compare May 23, 2023 08:39
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2023
@fuxiaohei fuxiaohei force-pushed the feat/artifact-upload-directories branch from 3e1cff3 to 2614c5e Compare June 2, 2023 10:33
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 2, 2023
@a1012112796 a1012112796 added the topic/gitea-actions related to the actions of Gitea label Jun 5, 2023
@fuxiaohei fuxiaohei marked this pull request as ready for review June 14, 2023 03:09
@lunny lunny mentioned this pull request Jun 29, 2023
Closed
@lunny lunny added this to the 1.21.0 milestone Jun 29, 2023
@AndyTempel AndyTempel mentioned this pull request Jul 2, 2023
Closed
@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 3, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 3, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 20, 2023
@lunny lunny merged commit f3d293d into go-gitea:main Jul 21, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 21, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 21, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
e1663fa 
* giteaoffical/main: (22 commits)
  Serve pre-defined files in "public", add "security.txt", add CORS header for ".well-known" (go-gitea#25974)
  Use frontend fetch for branch dropdown component  (go-gitea#25719)
  Remove commit status running and warning from the dashboard repo list (go-gitea#26036)
  Refactor to use urfave/cli/v2 (go-gitea#25959)
  Remove commit status running and warning to align GitHub (go-gitea#25839)
  Fix escape problems in the branch selector (go-gitea#25875)
  Update README.md to fix the broken link of Hugo (go-gitea#26008)
  Support copy protected branch from template repository (go-gitea#25889)
  Update JS dependencies (go-gitea#26025)
  Reduce margins on admin pages (go-gitea#26026)
  Actions Artifacts support uploading multiple files and directories (go-gitea#24874)
  [skip ci] Updated translations via Crowdin
  Remove redundant "RouteMethods" method (go-gitea#26024)
  Adding remaining enum for migration repo model type. (go-gitea#26021)
  RPM Registry: Show zypper commands for SUSE based distros as well (go-gitea#25981)
  Fix the route for pull-request's authors (go-gitea#26016)
  Remove nfnt/resize and oliamb/cutter (go-gitea#25999)
  Correctly refer to dev tags as nightly in the docker docs (go-gitea#26004)
  Fix env config parsing for "GITEA____APP_NAME" (go-gitea#26001)
  Add file status for API "Get a single commit from a repository" (go-gitea#16205) (go-gitea#25831)
  ...
@fuxiaohei fuxiaohei mentioned this pull request Aug 24, 2023
Closed
@fuxiaohei fuxiaohei mentioned this pull request Sep 9, 2023
Closed
@YueLengM YueLengM mentioned this pull request Sep 15, 2023
Closed
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 21, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

@a1012112796 a1012112796 Awaiting requested review from a1012112796

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
7 participants
@fuxiaohei @lunny @silverwind @wxiaoguang @wolfogre @GiteaBot @a1012112796