Fix some tests : make coverage -> test #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfranz
suggested changes
Sep 11, 2017
There was a problem hiding this comment.
The test still fails: https://drone.gitea.io/go-gitea/gitea/499/1/test-mysql
jonasfranz
suggested changes
Sep 11, 2017
modules/mailer/mailer.go
Outdated
| @@ -42,7 +42,7 @@ func NewMessageFrom(to []string, from, subject, body string) *Message { | |||
|
|
|||
| plainBody, err := html2text.FromString(body) | |||
| if err != nil || setting.MailService.SendAsPlainText { | |||
| if strings.Contains(base.TruncateString(body, 100), "<html>"){ | |||
| if strings.Contains(base.TruncateString(body, 100), "<html>") { | |||
There was a problem hiding this comment.
Please revert a885c7f since theire is already a PR for this: #2490
|
@JonasFranzDEV Yes, I haven't look in detail for the part still failling. I have mostly look for the what happen aroung the GPG part since I have worked on it. ^^ |
tboerger
added
the
lgtm/need 2
sapk
force-pushed
the
fix-tests-again
branch
from
a885c7f
to
1a2b10e
Compare
sapk
changed the title
lafriks
force-pushed
the
fix-tests-again
branch
3 times, most recently
from
8aa5434
to
d882aed
Compare
|
But why so many files changed? |
lunny
added
the
topic/build
lafriks
force-pushed
the
fix-tests-again
branch
from
d882aed
to
9292bd7
Compare
|
@lunny I just moved |
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Sep 12, 2017
|
LGTM |
tboerger
added
lgtm/done
|
thx @lafriks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make coverage use mysql database in paralell than test-mysql. That introduce test fails for test like GPG that insert key at runtime.
And some quick fix of missed error during PRs.