Add init support of orgmode document type on file view and readme #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/feature
This was referenced Sep 17, 2017
|
CI failed seems unrelated. |
tboerger
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/org-mode-support2
branch
from
13a84bc
to
8403f68
Compare
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
=========================================
Coverage ? 27.07%
=========================================
Files ? 86
Lines ? 17119
Branches ? 0
=========================================
Hits ? 4635
Misses ? 11809
Partials ? 675
Continue to review full report at Codecov.
|
jonasfranz
reviewed
Sep 18, 2017
| ) | ||
|
|
||
| const AppURL = "http://localhost:3000/" | ||
| const Repo = "gogits/gogs" |
There was a problem hiding this comment.
No reason. Just copied from markdown test.
ethantkoenig
suggested changes
Sep 20, 2017
main.go
Outdated
| @@ -14,6 +14,10 @@ import ( | |||
| "code.gitea.io/gitea/modules/log" | |||
| "code.gitea.io/gitea/modules/setting" | |||
| "github.com/urfave/cli" | |||
|
|
|||
| // register supported doc types | |||
| _ "code.gitea.io/gitea/modules/markup/markdown" | |||
lunny
force-pushed
the
lunny/org-mode-support2
branch
from
43f9aac
to
a3566aa
Compare
ethantkoenig
approved these changes
Sep 20, 2017
sapk
approved these changes
Sep 20, 2017
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
ethantkoenig
approved these changes
Sep 21, 2017
|
|
||
| test := func(input, expected string) { | ||
| buffer := RenderString(input, setting.AppSubURL, nil, false) | ||
| assert.Equal(t, strings.TrimSpace(expected), strings.TrimSpace(string(buffer))) |
There was a problem hiding this comment.
nit: unnecessary cast of buffer
|
|
||
| test := func(input, expected string) { | ||
| buffer := RenderString(input, setting.AppSubURL, nil, false) | ||
| assert.Equal(t, strings.TrimSpace(expected), strings.TrimSpace(string(buffer))) |
There was a problem hiding this comment.
nit: unnecessary cast of buffer
lunny
force-pushed
the
lunny/org-mode-support2
branch
from
aea4190
to
f2eac3d
Compare
|
@ethantkoenig done. |
This was referenced Sep 21, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will be part of #374 and replace #1527