Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integration tests more user-friendly #2536

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

ethantkoenig
Copy link
Member

Check that ./gitea binary exists, and don't print buffer.String() in assert message, since the buffer may contain an entire HTML page.

@lafriks
Copy link
Member

lafriks commented Sep 18, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 18, 2017
@lafriks lafriks added this to the 1.3.0 milestone Sep 18, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b0f7457). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2536   +/-   ##
=========================================
  Coverage          ?   26.96%           
=========================================
  Files             ?       84           
  Lines             ?    16906           
  Branches          ?        0           
=========================================
  Hits              ?     4559           
  Misses            ?    11672           
  Partials          ?      675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f7457...a303b89. Read the comment docs.

@lunny
Copy link
Member

lunny commented Sep 18, 2017

I think we should find a method to only run one integration test function.

@sapk
Copy link
Member

sapk commented Sep 18, 2017

@lunny It is possible manually like any go test (with little sugar ^^) : go test -c code.gitea.io/gitea/integrations -o integrations.sqlite.test -tags 'sqlite' && GITEA_ROOT="$GOPATH/src/code.gitea.io/gitea" GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test -test.v -test.run GPG

@sapk
Copy link
Member

sapk commented Sep 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2017
@lunny
Copy link
Member

lunny commented Sep 18, 2017

@sapk I know that, I mean a friendly method.

@lunny lunny merged commit 6c6533f into go-gitea:master Sep 18, 2017
@sapk
Copy link
Member

sapk commented Sep 18, 2017

@lunny Maybe by adding local arg for test TEST_MASK ?

@ethantkoenig ethantkoenig deleted the tests/friendly branch September 25, 2017 05:04
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants