Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fmt errors #2544

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Fix fmt errors #2544

merged 2 commits into from
Sep 19, 2017

Conversation

ethantkoenig
Copy link
Member

With the recent changes to .drone.yml, we should double check that make fmt-check (or something that has it as a dependency) always runs in CI.

@ethantkoenig ethantkoenig mentioned this pull request Sep 19, 2017
Merged
@lunny lunny added this to the 1.3.0 milestone Sep 19, 2017
@lunny
Copy link
Member

lunny commented Sep 19, 2017

depends on #2547 ?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2017
@ethantkoenig
Copy link
Member Author

@lunny yes

@lafriks
Copy link
Member

lafriks commented Sep 19, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 19, 2017
@codecov-io
Copy link

Codecov Report

Merging #2544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2544   +/-   ##
=======================================
  Coverage   27.21%   27.21%           
=======================================
  Files          85       85           
  Lines       16955    16955           
=======================================
  Hits         4615     4615           
  Misses      11665    11665           
  Partials      675      675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23645fe...06a9970. Read the comment docs.

@lunny
Copy link
Member

lunny commented Sep 19, 2017

LGTM

@lunny
Copy link
Member

lunny commented Sep 19, 2017

make L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 19, 2017
@lunny lunny merged commit a1ed239 into go-gitea:master Sep 19, 2017
@ethantkoenig ethantkoenig deleted the fix/fmt branch September 19, 2017 15:08
ethantkoenig added a commit to ethantkoenig/gitea that referenced this pull request Sep 20, 2017
@ethantkoenig
Fix fmt errors (go-gitea#2544)
842ee9e
lafriks pushed a commit that referenced this pull request Sep 20, 2017
@ethantkoenig @lafriks
Backport: Fix lint, fmt and integration testing errors (#2553)
f014e42 
* Fix lint errors

* Fix fmt errors (#2544)

* Hotfix for integration testing (#2473)

* Hotfix for integration testing
@lafriks lafriks added the backport/done All backports for this PR have been created label Sep 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @lunny @lafriks @codecov-io @tboerger