-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use named ActionType constants in template helper #2545
Use named ActionType constants in template helper #2545
Conversation
Shouldn't this be a problem in https://github.com/go-gitea/gitea/blob/master/templates/user/dashboard/feeds.tmpl? I thought |
@daviian No, the template engine is smart enough to type-cast as needed. I ran it locally just to be sure. |
f334448
to
f34c8bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2545 +/- ##
=======================================
Coverage 27.21% 27.21%
=======================================
Files 85 85
Lines 16955 16955
=======================================
Hits 4615 4615
Misses 11665 11665
Partials 675 675
Continue to review full report at Codecov.
|
LGTM 😄 even if it doesn't work for me^^ |
LGTM |
LGTM |
Make LG-TM work |
LGTM |
Use constants instead of magic numbers in template helper. Also resolves a related
TODO
cc @daviian