-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tool dependencies, lock govulncheck and actionlint #25655
Conversation
Can try a backport, if it's automatic 😆. |
Looks like golangci brought up a few thousand new failures 😵. Any insights welcome. |
Wonder what to do about Replace all affected |
This comment was marked as outdated.
This comment was marked as outdated.
We already have set |
There were some PRs for such fixing, but there was a bug in old That's why it finds more now ...... |
Ah, that explains the sudden influx of new failures. |
277 lint errors left. |
well next smal pull #25713 we will get there ... |
just a step towards #25655 and some related refactoring
113 errors left 👍 |
All done, 0cef69b Some code like |
} | ||
if err = n.loadComment(ctx); err != nil { | ||
return | ||
return err | ||
} | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker.
https://github.com/go-gitea/gitea/pull/25655/files#diff-a9a3a131e7fcfb1641580afd9381afe56f44022d9a5e4ba651361f9230fa1694L386
what is the need of return err
we can put return nil
Sometime it hard to recall the Named return values
in golang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well we do report the error back so we need to retur err and not nil here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also a similar case of #25655 (comment)
Some code like
return mode, fname, sha, n, err
andreturn sha, typ, size, err
are written as is intentionally, to avoid breaking.
The purpose of it is to avoid changing old code too much (which might break something or cause difficulty for reviewing).
In short: In Golang, return err
is always right for named return values, but if you want to change it, the developers should always spend more time on thinking about "what value should be returned".
* giteaofficial/main: (31 commits) Fix WORK_DIR for docker (root) image (go-gitea#25738) Avoid amending the Rebase and Fast-forward merge if there is no message template (go-gitea#25779) Show edit title button on commits tab of PR, too (go-gitea#25791) Make "install page" respect environment config (go-gitea#25648) Enable H014 and H023 djlint rules (go-gitea#25786) Restructure issue list template, styles (go-gitea#25750) Fix notification list bugs (go-gitea#25781) Revert package access change from go-gitea#23879 (go-gitea#25707) Make route middleware/handler mockable (go-gitea#25766) Update tool dependencies, lock govulncheck and actionlint (go-gitea#25655) Test if container blob is accessible before mounting (go-gitea#22759) Always pass 6-digit hex color to monaco (go-gitea#25780) Fix the wrong default branch name displayed by checkout (go-gitea#25777) Tweak repo topics bar (go-gitea#25769) docs: rootless docker ssh's default port is 2222 (go-gitea#25771) Repository Archived text title center align (go-gitea#25767) Update JS dependencies, misc tweaks (go-gitea#25768) Clarify "text-align" CSS helpers, fix clone button padding (go-gitea#25763) Switch to `vite-string-plugin` (go-gitea#25762) Newly pushed branches hints on repository home page (go-gitea#25715) ...
govulncheck
andactionlint
to their latest tags