-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix margin on the new/edit milestone
page
#25801
Fix margin on the new/edit milestone
page
#25801
Conversation
cb29c31
to
25760b3
Compare
Don't spam me with mentions please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the small code style things, but overall a nice fix. I think we'll have to get rid of more of these grid layouts as they impact responsiveness.
Is there a reason you switched the button position? |
I found these article. |
Co-authored-by: Denys Konovalov <privat@denyskon.de>
<div class="divider"></div> | ||
<div class="ui right"> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs "gt-text-right", and make the button order as "Cancel" "Submit".
Because, all other Gitea's UI use such layout, it's better to keep consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new/edit milestone
page
I was unable to create a backport for 1.20. @puni9869, please send one manually. 🍵
|
* giteaofficial/main: Fix incorrect release count (go-gitea#25879) Add Github related extensions in devcontainer (go-gitea#25800) Add error info if no user can fork the repo (go-gitea#25820) Fix wrong usage of PathEscapeSegments in branch list page (go-gitea#25864) fix incorrect repo url when changed the case of ownername (go-gitea#25733) Upgrade go dependencies (go-gitea#25819) Don't stack PR tab menu on small screens (go-gitea#25789) Link to list of vulnerabilities (go-gitea#25872) [skip ci] Updated translations via Crowdin move issue filters to shared template (go-gitea#25729) [skip ci] Updated translations via Crowdin Remove `git.FileBlame` (go-gitea#25841) Fix empty project displayed in issue sidebar (go-gitea#25802) Update blog links (go-gitea#25843) Fix margin on the `new/edit milestone` page (go-gitea#25801) Do not "guess" the file encoding/BOM when using API to upload files (go-gitea#25828)
This needs to be backport |
Yes. Q. Do I need to send from my side? |
There is some distortion in desktop and mobile ui for new/edit milestone page.
Fixing the new/edit milestone page for desktop and mobile ui
Design background
https://uxplanet.org/primary-secondary-action-buttons-c16df9b36150
https://balsamiq.com/learn/articles/button-design-best-practices/
Screen shots
Before:
After