Improvements of releases list and tags list

[Zettat123]

Follow #23465 and #25624

This PR introduces the following improvements:

• We do not need to call GetTags to get tags because tags have been loaded by RepoAssignment
  

  gitea/modules/context/repo.go

  Lines 663 to 668 in ef90fdb

  	tags, err := repo_model.GetTagNamesByRepoID(ctx, ctx.Repo.Repository.ID)
  	if err != nil {
  	ctx.ServerError("GetTagNamesByRepoID", err)
  	return cancel
  	}
  	ctx.Data["Tags"] = tags

• Similarly, the number of tags and releases also have been loaded by RepoAssignment, so the related code has been removed from the handlers. The query condition of GetReleaseCountByRepoID in RepoAssignment has been changed to include draft releases.
  

  gitea/modules/context/repo.go

  Lines 538 to 551 in ef90fdb

  	ctx.Data["NumTags"], err = repo_model.GetReleaseCountByRepoID(ctx, ctx.Repo.Repository.ID, repo_model.FindReleasesOptions{
  	IncludeDrafts: true,
  	IncludeTags: true,
  	HasSha1: util.OptionalBoolTrue, // only draft releases which are created with existing tags
  	})
  	if err != nil {
  	ctx.ServerError("GetReleaseCountByRepoID", err)
  	return nil
  	}
  	ctx.Data["NumReleases"], err = repo_model.GetReleaseCountByRepoID(ctx, ctx.Repo.Repository.ID, repo_model.FindReleasesOptions{})
  	if err != nil {
  	ctx.ServerError("GetReleaseCountByRepoID", err)
  	return nil
  	}

• releasesOrTags function has been removed. The code for rendering releases list and tags list moved to Releases and TagList respectively.

[wxiaoguang]

Is there an assertion for ctx.Data["NumReleases"]?

[wxiaoguang]

Hmm .... I think the test code is not ideal. Calling Releases directly makes the middlewares never executed.

If it doesn't test NumReleases logic, it's better to remove this code block.

[Zettat123]

Sorry for replying so late. I agree with your opinion that the test code is not ideal. Right now this unit test cannot work without the RepoAssignment middleware. I tried moving it to integration tests, then I found there was already a TestViewReleaseListNoLogin which tests the release list.

gitea/tests/integration/release_test.go

Lines 134 to 174 in 5600504

	func TestViewReleaseListNoLogin(t *testing.T) {
	defer tests.PrepareTestEnv(t)()
	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 57, OwnerName: "user2", LowerName: "repo-release"})
	link := repo.Link() + "/releases"
	req := NewRequest(t, "GET", link)
	rsp := MakeRequest(t, req, http.StatusOK)
	htmlDoc := NewHTMLParser(t, rsp.Body)
	releases := htmlDoc.Find("#release-list li.ui.grid")
	assert.Equal(t, 5, releases.Length())
	links := make([]string, 0, 5)
	commitsToMain := make([]string, 0, 5)
	releases.Each(func(i int, s *goquery.Selection) {
	link, exist := s.Find(".release-list-title a").Attr("href")
	if !exist {
	return
	}
	links = append(links, link)
	commitsToMain = append(commitsToMain, s.Find(".ahead > a").Text())
	})
	assert.EqualValues(t, []string{
	"/user2/repo-release/releases/tag/empty-target-branch",
	"/user2/repo-release/releases/tag/non-existing-target-branch",
	"/user2/repo-release/releases/tag/v2.0",
	"/user2/repo-release/releases/tag/v1.1",
	"/user2/repo-release/releases/tag/v1.0",
	}, links)
	assert.EqualValues(t, []string{
	"1 commits", // like v1.1
	"1 commits", // like v1.1
	"0 commits",
	"1 commits", // should be 3 commits ahead and 2 commits behind, but not implemented yet
	"3 commits",
	}, commitsToMain)
	}

Maybe we can remove TestNewReleasesList from unit tests?

[wxiaoguang]

Why TestNewReleasesList is removed? Could it be kept?

[Zettat123]

Why TestNewReleasesList is removed? Could it be kept?

Because ctx.Data["NumReleases"] is required in TestNewReleasesList. However, NumReleases is assigned in the RepoAssignment middleware and this test calls the handler(Release) directly without using the middleware. So TestNewReleasesList cannot work now.

In addition, as my previous comment said, I think the TestViewReleaseListNoLogin integration test is able to test the logic of the handler.

[wxiaoguang]

The test code and TargetBehind was introduced by #24470

If I understand correctly, only the removed code tested the TargetBehind ?

[Zettat123]

The test code and TargetBehind was introduced by #24470

If I understand correctly, only the removed code tested the TargetBehind ?

To test TargetBehind, I added TestNewReleasesList back and renamed it to TestCalReleaseNumCommitsBehind in a8050b7