Remove direct user adding to organization members

[lafriks]

Reason for this as this button is very confusing and there is no much point in adding user directly as organization member he will still not be able to do anything more than if he would not be added. It just makes people more confusion why user can not access or do anything. Users should be to added to repository members by adding user to one or more this organization team

[codecov-io]

Codecov Report

Merging #2641 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2641   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files          87       87           
  Lines       17176    17176           
=======================================
  Hits         4659     4659           
  Misses      11837    11837           
  Partials      680      680

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42dbdb...1eebcb7. Read the comment docs.

[Morlinest]

LGTM

[lunny]

So why github has this feature?

[lafriks]

@lunny because in github that actually grants some rights for members (like creating new repositories under that organization and new teams) while in Gitea it does nothing and all rights are checked only by team. And to be honest Gitea way to me seems a lot better and could be used for more use cases

[lunny]

LGTM

[Morlinest]

One question before sleep. What about users that was added this way? Do you want to ignore it or make migration to remove them?

[lunny]

@Morlinest they will stay the same behavior with before. Organization owners could remove them from organization or add them to some teams.

[lafriks]

They do not do any harm so they can stay. This change is just so that it would be less confusing and there would not be regular questions and issues that user is added to org. members but he still does not see nor can do anything