Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve repo sub menu #26531

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Improve repo sub menu #26531

merged 4 commits into from
Aug 22, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Aug 16, 2023 •
edited
Loading

Before:
image

After:
image

Icons are not in the middle of the line.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 16, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2023
@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Aug 16, 2023
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Aug 16, 2023 •
edited
Loading

You could just put flex-items-block on the parent container, and use <a> for items.

Or, use flex-text-block or flex-text-inline for items.

@yp05327
Copy link
Contributor Author

yp05327 commented Aug 22, 2023

This pr is ready.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 22, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 22, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 22, 2023
@lunny lunny enabled auto-merge (squash) August 22, 2023 08:43
@lunny lunny merged commit 75689b8 into go-gitea:main Aug 22, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 22, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 23, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a34a70c 
* giteaofficial/main:
  Fix counting and filtering on the dashboard page for issues (go-gitea#26657)
  add mfa doc (go-gitea#26654)
  [Refactor] getIssueStatsChunk to move inner function into own one (go-gitea#26671)
  Use line-height: normal by default (go-gitea#26635)
  Improve repo sub menu (go-gitea#26531)
  Fix organization list in dashboard (go-gitea#26650)
@yp05327 yp05327 deleted the improve-repo-sub-menu branch October 23, 2023 01:40
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yp05327 @wxiaoguang @lunny @delvh @GiteaBot