Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintainer label for docker file #2658

Merged
merged 3 commits into from
Oct 5, 2017
Merged

Add maintainer label for docker file #2658

merged 3 commits into from
Oct 5, 2017

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Oct 5, 2017

MAINTAINER has been deprecated for docker.

@codecov-io
Copy link

codecov-io commented Oct 5, 2017 •
edited
Loading

Codecov Report

Merging #2658 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2658   +/-   ##
=======================================
  Coverage   27.13%   27.13%           
=======================================
  Files          86       86           
  Lines       17061    17061           
=======================================
  Hits         4629     4629           
  Misses      11754    11754           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e1c29...0e5b2e9. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2017
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Oct 5, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 5, 2017
@lafriks
Copy link
Member

lafriks commented Oct 5, 2017

@appleboy should it be same as in copyright The Gitea Authors?

@appleboy
Copy link
Member Author

appleboy commented Oct 5, 2017

Change to Gitea Authors? right?

@lunny
Copy link
Member

lunny commented Oct 5, 2017

@appleboy agree with @lafriks otherwise LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 5, 2017
@appleboy
Add maintainer label for docker file
06418e8 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update
f9ccf8c 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
Copy link
Member Author

appleboy commented Oct 5, 2017

Done and rebase.

@lafriks
Copy link
Member

lafriks commented Oct 5, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2017
@sapk
Copy link
Member

sapk commented Oct 5, 2017

LGTM
Could we setup an alias like security@gitea.io to add. Ex: maintainers@gitea.io or docker@gitea.io ? A cool hack could be to have it send to a discord channel.

@appleboy appleboy merged commit 6867464 into go-gitea:master Oct 5, 2017
@appleboy appleboy deleted the maintaner branch October 5, 2017 08:41
@appleboy
Copy link
Member Author

appleboy commented Oct 5, 2017

@sapk Can't see any API from zoho document to trigger webhook after we got the email.

https://www.zoho.com/mail/help/api/

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@appleboy @codecov-io @lafriks @lunny @sapk @tboerger