Fix some slice append usages

[harryzcy]

No description provided.

[wxiaoguang]

Off-topic: in most cases, there is no need to play with make(slice, 0, len) since Gitea is not a time-critical high performance server and most code is not on the hot path, using it or not, it at most only affects nanosecond-level (10^-9) performance, while a normal page request is around 10-200 millisecond (10^-3).

[KN4CK3R]

Off-topic: in most cases, there is no need to play with make(slice, 0, len) since Gitea is not a time-critical high performance server and most code is not on the hot path, using it or not, it at most only affects nanosecond-level (10^-9) performance, while a normal page request is around 10-200 millisecond (10^-3).

But here it's not a performance improvement but a bugfix because the slices a prepended with default elements.

s := make([]string, 5)
s = append(s, "foo") // []string{"", "", "", "", "", "foo"}

[wxiaoguang]

Off-topic: in most cases, there is no need to play with make(slice, 0, len) since Gitea is not a time-critical high performance server and most code is not on the hot path, using it or not, it at most only affects nanosecond-level (10^-9) performance, while a normal page request is around 10-200 millisecond (10^-3).

But here it's not a performance improvement but a bugfix because the slices a prepended with default elements.

s := make([]string, 5)
s = append(s, "foo") // []string{"", "", "", "", "", "foo"}

Yup, I know, so I said "off-topic"

Actually, force using "make(...)" would cause more similar bugs. var slice []int is always safe and can't be wrong.