Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SSH Key / GPG Key / Deploy Key UI #26949

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Improve SSH Key / GPG Key / Deploy Key UI #26949

merged 2 commits into from
Sep 7, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Sep 6, 2023 •
edited
Loading

Also follow #26829 (I have to admit that I didn't make the UI good in that PR, my change didn't work well with the padding game).

Major changes:

  1. In many cases, the flex-list has previous and next gt-hidden siblings, so relax the CSS selector to remove all ".segument .flex-list" paddings.
  2. Make the "Add key" button can toggle
  3. Move help message into the related segment(panel). Otherwise users would misread the message, eg: the SSH help seemed for GPG because they are so near
  4. Move modal element into the segment element, otherwise it affects the layout

Before:

image

After:

image

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 6, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Sep 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2023
@wxiaoguang wxiaoguang changed the title Improve SSH key / GPG key / Deploy Key UI Improve SSH Key / GPG Key / Deploy Key UI Sep 6, 2023
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Sep 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 7, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 7, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) September 7, 2023 01:10
@wxiaoguang wxiaoguang merged commit 419003a into go-gitea:main Sep 7, 2023
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 7, 2023
@wxiaoguang wxiaoguang deleted the improve-panel branch September 7, 2023 02:03
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 7, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
58c0c0b 
* giteaofficial/main:
  Fix schedule actions still running even if workflow disalbed (go-gitea#26939)
  Fix the missing repo count (go-gitea#26942)
  Improve SSH Key / GPG Key / Deploy Key UI (go-gitea#26949)
  [skip ci] Updated translations via Crowdin
  Update nginx recommendations (go-gitea#26924)
  docs: Update Profile README information (go-gitea#26947)
  Fix scoped label layout (go-gitea#26932)
  Move createrepository from module to service layer (go-gitea#26927)
  Add a documentation note for Windows Service (go-gitea#26938)
  allow "latest" to be used in release vTag when downloading file (go-gitea#26748)
  Extract common code to new template (go-gitea#26933)
  Show always repo count in header (go-gitea#26842)
  Show always repo count in header (go-gitea#26842)
  Artifacts retention and auto clean up (go-gitea#26131)
  Fix UI anomalies (go-gitea#26929)
  Fix the display of org level badges  (go-gitea#26504)
@delvh delvh added the type/enhancement An improvement of existing functionality label Sep 13, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @lunny @silverwind @techknowlogick @GiteaBot @delvh