Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce usage of db.DefaultContext #27073

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Reduce usage of db.DefaultContext #27073

merged 7 commits into from
Sep 14, 2023

Conversation

JakobDev
Copy link
Contributor

Part of #27065

This reduces the usage of db.DefaultContext. I think I've got enough files for the first PR. When this is merged, I will continue working on this.

Considering how many files this PR affect, I hope it won't take to long to merge, so I don't end up in the merge conflict hell.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 14, 2023
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Sep 14, 2023
@delvh delvh added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Sep 14, 2023
@delvh
Copy link
Member

delvh commented Sep 14, 2023

(That's the benefit of refactorings: We are aware of them becoming outdated soon, so we've adopted the rule of merging or closing them within a week.)

wxiaoguang
wxiaoguang reviewed Sep 14, 2023
View reviewed changes
models/org_team.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Sep 14, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2023
delvh
delvh approved these changes Sep 14, 2023
View reviewed changes
modules/metrics/collector.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) September 14, 2023 16:35
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 14, 2023
@techknowlogick techknowlogick merged commit 76659b1 into go-gitea:main Sep 14, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 14, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 14, 2023
@JakobDev JakobDev deleted the nodefaultctx branch September 14, 2023 17:34
@techknowlogick techknowlogick modified the milestones: 1.22.0, 1.21.0 Sep 15, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JakobDev @delvh @techknowlogick @wxiaoguang @GiteaBot