Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semantic-ui style conflict with v-cloak #2722

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Fix semantic-ui style conflict with v-cloak #2722

merged 2 commits into from
Oct 17, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 16, 2017

Dropdown was shown unrendered (as template) on page load. This change fixes this

@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 16, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 16, 2017
@codecov-io
Copy link

codecov-io commented Oct 16, 2017 •
edited
Loading

Codecov Report

Merging #2722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2722   +/-   ##
=======================================
  Coverage   26.96%   26.96%           
=======================================
  Files          87       87           
  Lines       17297    17297           
=======================================
  Hits         4664     4664           
  Misses      11953    11953           
  Partials      680      680

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4190f8...143a7d6. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 16, 2017
@lafriks lafriks force-pushed the fix/v-cloak-semantic-ui-css-bug branch from dd3b9c4 to 081fa58 Compare October 16, 2017 22:27
@lafriks lafriks force-pushed the fix/v-cloak-semantic-ui-css-bug branch from 081fa58 to a3a6044 Compare October 16, 2017 22:50
@Morlinest
Copy link
Member

tested LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 16, 2017
@daviian
Copy link
Member

daviian commented Oct 17, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2017
@appleboy appleboy merged commit af4a094 into go-gitea:master Oct 17, 2017
@lafriks lafriks deleted the fix/v-cloak-semantic-ui-css-bug branch October 17, 2017 07:51
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lafriks @codecov-io @Morlinest @daviian @appleboy @tboerger