Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename TotalTimes() to TotalTimesForEachUser() #27261

Merged
merged 5 commits into from
Sep 29, 2023
Merged

rename TotalTimes() to TotalTimesForEachUser() #27261

merged 5 commits into from
Sep 29, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 25, 2023 •
edited
Loading

make function name more descriptive as it would otherwise imply it could be used for e.g. #26672 too ...

Sponsored by Kithara Software GmbH

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 25, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2023
@lunny
Copy link
Member

lunny commented Sep 25, 2023

It depends on FindTrackedTimesOptions. How about there are two or three users in this options?

delvh
delvh approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, TotalTimesPerUser.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2023
@6543
Copy link
Member Author

6543 commented Sep 28, 2023

It depends on FindTrackedTimesOptions. How about there are two or three users in this options?

in this cases the option misses totally the point and that's why we need to rename this function!
so using this function in combination with the user filter is a missuse ...
... I can optionally add a check and return an error in this case

@6543
Copy link
Member Author

6543 commented Sep 28, 2023

Alternatively, TotalTimesPerUser.

I don't mind whatever is more preferred ... as long as the name is not so miss-leading as it is now ;)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 29, 2023
@lunny lunny enabled auto-merge (squash) September 29, 2023 11:44
@lunny lunny merged commit 2a2b0cb into go-gitea:main Sep 29, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 29, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 29, 2023
@6543 6543 deleted the rename_TotalTimes branch September 30, 2023 10:34
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @silverwind @delvh @GiteaBot