Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More db.DefaultContext refactor #27265

Merged
merged 3 commits into from
Sep 29, 2023
Merged

More db.DefaultContext refactor #27265

merged 3 commits into from
Sep 29, 2023

Conversation

JakobDev
Copy link
Contributor

Part of #27065

This PR touches functions used in templates. As templates are not static typed, errors are harder to find, but I hope I catch it all. I think some tests from other persons do not hurt.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 25, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Sep 25, 2023
@JakobDev JakobDev changed the title More db.DefaultContext refactor More db.DefaultContext refactor Sep 25, 2023
@delvh delvh added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 25, 2023
delvh
delvh approved these changes Sep 25, 2023
View reviewed changes
templates/projects/new.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2023
@lunny
Copy link
Member

lunny commented Sep 27, 2023 

Render failed, failed to render template: user/dashboard/dashboard, error: template error: builtin(static):user/dashboard/feeds:84:20 : executing "user/dashboard/feeds" at <.GetRepoLink>: wrong number of args for GetRepoLink: want 1 got 0
----------------------------------------------------------------------
					{{$repoLink := .GetRepoLink}}
					               ^
----------------------------------------------------------------------

@JakobDev
Copy link
Contributor Author

Done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 29, 2023
@lunny lunny enabled auto-merge (squash) September 29, 2023 11:41
@lunny lunny merged commit cf0df02 into go-gitea:main Sep 29, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 29, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 29, 2023
@delvh delvh added the backport/v1.21 This PR should be backported to Gitea 1.21 label Sep 29, 2023
@JakobDev JakobDev deleted the nodefaultctx branch September 29, 2023 12:43
@GiteaBot GiteaBot mentioned this pull request Sep 29, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 29, 2023
@JakobDev @GiteaBot
More db.DefaultContext refactor (go-gitea#27265)
cc638c6 
Part of go-gitea#27065

This PR touches functions used in templates. As templates are not static
typed, errors are harder to find, but I hope I catch it all. I think
some tests from other persons do not hurt.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Sep 29, 2023
silverwind pushed a commit that referenced this pull request Sep 29, 2023
@GiteaBot @JakobDev
More db.DefaultContext refactor (#27265) (#27347)
f13a294 
Backport #27265 by @JakobDev

Part of #27065

This PR touches functions used in templates. As templates are not static
typed, errors are harder to find, but I hope I catch it all. I think
some tests from other persons do not hurt.

Co-authored-by: JakobDev <jakobdev@gmx.de>
@CaiCandong CaiCandong mentioned this pull request Oct 1, 2023
Closed
@CaiCandong CaiCandong mentioned this pull request Oct 1, 2023
Merged
6543 pushed a commit that referenced this pull request Oct 1, 2023
@CaiCandong
Fix missing ctx for GetRepoLink in dashboard (#27372)
6b65c41 
As title
Fix #27369
Regression of #27265
@GiteaBot GiteaBot mentioned this pull request Oct 1, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 1, 2023
@CaiCandong @GiteaBot
Fix missing ctx for GetRepoLink in dashboard (go-gitea#27372)
e5b1bda 
As title
Fix go-gitea#27369
Regression of go-gitea#27265
6543 pushed a commit that referenced this pull request Oct 1, 2023
@GiteaBot @CaiCandong
Fix missing ctx for GetRepoLink in dashboard (#27372) (#27375)
e9340ce 
Backport #27372 by @CaiCandong

As title
Fix #27369
Regression of #27265

Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
This was referenced Oct 4, 2023
Closed
Merged
6543 pushed a commit that referenced this pull request Oct 4, 2023
@CaiCandong
Fix missing ctx in new_form.tmpl (#27434)
df56b1b 
Fix  #27432
Regression of #27265
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 4, 2023
@CaiCandong @GiteaBot
Fix missing ctx in new_form.tmpl (go-gitea#27434)
2057f29 
Fix  go-gitea#27432
Regression of go-gitea#27265
@GiteaBot GiteaBot mentioned this pull request Oct 4, 2023
Merged
silverwind pushed a commit that referenced this pull request Oct 4, 2023
@GiteaBot @CaiCandong
Fix missing ctx in new_form.tmpl (#27434) (#27438)
1ff6b77 
Backport #27434 by @CaiCandong

Fix  #27432
Regression of #27265

Co-authored-by: CaiCandong <50507092+CaiCandong@users.noreply.github.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JakobDev @lunny @wxiaoguang @delvh @GiteaBot