Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even more db.DefaultContext refactor #27352

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Even more db.DefaultContext refactor #27352

merged 8 commits into from
Oct 3, 2023

Conversation

JakobDev
Copy link
Contributor

Part of #27065

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 29, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 29, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Sep 29, 2023
@delvh delvh added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 29, 2023
delvh
delvh reviewed Sep 29, 2023
View reviewed changes
models/issues/issue_watch.go Outdated Show resolved Hide resolved
routers/web/repo/issue.go Outdated Show resolved Hide resolved
routers/web/repo/issue.go Outdated Show resolved Hide resolved
@delvh
Copy link
Member

delvh commented Oct 2, 2023

Should I apply the suggestions myself?

JakobDev and others added 3 commits October 2, 2023 18:39
@lunny lunny added this to the 1.22.0 milestone Oct 3, 2023
delvh
delvh approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as @lunny's request has been implemented.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed modifies/api This PR adds API routes or modifies them labels Oct 3, 2023
@lunny lunny enabled auto-merge (squash) October 3, 2023 09:58
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Oct 3, 2023
@lunny lunny merged commit cc5df26 into go-gitea:main Oct 3, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2023
@JakobDev JakobDev deleted the nodefaultctx branch October 3, 2023 15:19
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JakobDev @delvh @lunny @GiteaBot