Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IE unsupported javascript construction in branch dropdown #2736

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Fix IE unsupported javascript construction in branch dropdown #2736

merged 2 commits into from
Oct 19, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 18, 2017

Bug can be reproduced only in Internet Explorer where on page load there is JS syntax error

@lafriks lafriks added this to the 1.3.0 milestone Oct 18, 2017
@codecov-io
Copy link

codecov-io commented Oct 18, 2017 •
edited
Loading

Codecov Report

Merging #2736 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2736   +/-   ##
=======================================
  Coverage   26.91%   26.91%           
=======================================
  Files          87       87           
  Lines       17286    17286           
=======================================
  Hits         4652     4652           
  Misses      11955    11955           
  Partials      679      679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847272a...eafd510. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 18, 2017
@cez81
Copy link
Contributor

cez81 commented Oct 18, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 18, 2017
@lunny
Copy link
Member

lunny commented Oct 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 19, 2017
@lunny lunny merged commit 2222448 into go-gitea:master Oct 19, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @cez81 @lunny @tboerger