Refactor Find Sources and fix bug when view a user who belongs to an unactive auth source #27798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unactive auth source
lunny
added
type/bug
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
modifies/cli
lng2020
approved these changes
Oct 27, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Nov 2, 2023
GiteaBot
added
lgtm/done
KN4CK3R
reviewed
Nov 2, 2023
…ea into lunny/fix_unactive_auth_source
There was a problem hiding this comment.
There are some changes to these functions in #25165 to make them more generic. Could you utilize some of these update function names/args to make conflict merging easier?
I think the changes are the correct direction. I will help to resolve your PR's conflict after this merge. |
lunny
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.20. @lunny, please send one manually. 🍵 |
GiteaBot
added
backport/manual
|
I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵 |
lunny
removed
backport/manual
|
There are too many conflicts, so I think maybe it's not necessary to backport to v1.21 and v1.20. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 3, 2023
* upstream/main: Refactor Find Sources and fix bug when view a user who belongs to an unactive auth source (go-gitea#27798) [skip ci] Updated translations via Crowdin Add `Hide/Show all checks` button to commit status check (go-gitea#26284) Fix http protocol auth (go-gitea#27875) Display issue task list on project cards (go-gitea#27865) Reduce margin/padding on flex-list items and divider (go-gitea#27872)
Merged
KN4CK3R
pushed a commit
that referenced
this pull request
Nov 11, 2023
lunny
added a commit
that referenced
this pull request
Dec 11, 2023
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
…unactive auth source (go-gitea#27798) The steps to reproduce it. First, create a new oauth2 source. Then, a user login with this oauth2 source. Disable the oauth2 source. Visit users -> settings -> security, 500 will be displayed. This is because this page only load active Oauth2 sources but not all Oauth2 sources.
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Now that we have go-gitea#27798 we don't need the check from go-gitea#27870 anymore. With the check it's not possible to remove an inactive auth source from the user.
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Continue of go-gitea#27798 and move more functions to `db.Find` and `db.Count`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The steps to reproduce it.
First, create a new oauth2 source.
Then, a user login with this oauth2 source.
Disable the oauth2 source.
Visit users -> settings -> security, 500 will be displayed.
This is because this page only load active Oauth2 sources but not all Oauth2 sources.