Show Sendmail settings on admin config page #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cez81
force-pushed
the
sendmail_config
branch
from
6b6c1c8
to
10f9b54
Compare
Codecov Report
@@ Coverage Diff @@
## master #2782 +/- ##
=======================================
Coverage 27.18% 27.18%
=======================================
Files 88 88
Lines 17367 17367
=======================================
Hits 4721 4721
Misses 11961 11961
Partials 685 685Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
sapk
reviewed
Oct 25, 2017
templates/admin/config.tmpl
Outdated
| <dd>{{.Mailer.Host}}</dd> | ||
| {{else}} | ||
| <dt>{{.i18n.Tr "admin.config.mailer_use_sendmail"}}</dt> | ||
| <dd><i class="fa fa{{if .Mailer.UseSendmail}}-check{{end}}-square-o"></i></dd> |
There was a problem hiding this comment.
The if .Mailer.UseSendmail at this line could be removed since we check it ar L173.
|
Just a |
tboerger
added
lgtm/need 1
sapk
approved these changes
Oct 26, 2017
|
LGTM |
tboerger
added
lgtm/done
|
Make LG-TM work |
vdbt
pushed a commit
to vdbt/gitea
that referenced
this pull request
Oct 27, 2017
* Show Sendmail settings on admin config page * Remove unecessary if statement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title add the Sendmail setting to the config page
