Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: actions/act-runner: document running as a systemd service #27844

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

nodiscc
Copy link
Contributor

@nodiscc nodiscc commented Oct 30, 2023

This documents running act-runner as a systemd service under a dedicated user account.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2023
@nodiscc
Copy link
Contributor Author

nodiscc commented Oct 30, 2023

I would link to the specific issue on https://gitea.com/gitea/act_runner/issues/ requesting this, but gitea.com has been extremely slow for a few days, to the point of being unusable. Is this a known problem?

Edit: https://gitea.com/gitea/act_runner/issues/379

@techknowlogick techknowlogick added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.21 This PR should be backported to Gitea 1.21 labels Oct 30, 2023
@techknowlogick
Copy link
Member

@nodiscc if you're comfortable saying, which continent are you located on, and what timezone/time of day are you accessing Gitea.com? I'm running operations for gitea.com and so your feedback is helpful/appreciated :)

@lng2020
Copy link
Member

lng2020 commented Oct 31, 2023

Is there a particular concern to use - instead of _? Because the binary name is act_runner, if use -, then it is required to change its name.

@lunny
Copy link
Member

lunny commented Oct 31, 2023

It should be act_runner

@nodiscc
Copy link
Contributor Author

nodiscc commented Oct 31, 2023

which continent are you located on, and what timezone/time of day are you accessing Gitea.com

Europe, GMT+1. I just issued a request to https://gitea.com/gitea/act_runner/issues/nonexisting, if that helps you look through the logs (page load took 13s, https://gitea.com/assets/js/index.js?v=1.22.0~dev-233-g796ff26e0 didn't load at all, timeout)

Is there a particular concern to use - instead of _

Most executables from Debian packages use - instead of _, all user/group names use -, also _ is considered a word separator by many programs/editors, for consistency I always use - in file names unless there is a good reason.

$ ls /usr/bin/ | grep '\-' | wc -l
620
$ ls /usr/bin/ | grep '_' | grep -v x86|wc -l
105
$ grep '\-' /etc/passwd|wc -l
9
$ grep _ /etc/passwd | wc -l
0

Do you still want me to change it? Which parts (executable name? directory names? user name?)

@silverwind
Copy link
Member

silverwind commented Oct 31, 2023

I personally find - more common and friendly than _ and would even go as far as renaming the act_runner project to act-runner. I we check repos in https://gitea.com/gitea, it is certainly an exception from our repo naming schemes.

BTW if we use it for more than just a actions runner, a new name would be good as well. Maybe gitea-runner or gitea-worker.

@techknowlogick
Copy link
Member

Using - instead of _ has implications on text selection and copy/paste. By using _ in the binary name, it means when people double click on a part of the string for copying from docs etc, they will get the full act_runner instead of either just act or runner.

Regardless of which is better to use, as the built binary name uses _ right now, I recommend that the docs should use that to stay consistent.

(thanks for the docs PRs btw, they are very appreciated 😄 )

@lunny
Copy link
Member

lunny commented Nov 1, 2023

Yes, we can have other PRs to discuss/do the renaming. But currently, please keep consistent on this PR.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Nov 1, 2023
@nodiscc
Copy link
Contributor Author

nodiscc commented Nov 1, 2023

Changed all occurrences of act-runner to act_runner.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 1, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2023
@lunny lunny merged commit 665d12c into go-gitea:main Nov 1, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 1, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 1, 2023
…tea#27844)

This documents running `act-runner` as a systemd service under a
dedicated user account.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Nov 1, 2023
@nodiscc nodiscc deleted the patch-1 branch November 1, 2023 17:17
silverwind pushed a commit that referenced this pull request Nov 1, 2023
… (#27866)

Backport #27844 by @nodiscc

This documents running `act-runner` as a systemd service under a
dedicated user account.

Co-authored-by: nodiscc <nodiscc@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 2, 2023
* giteaofficial/main:
  Filter inactive auth sources (go-gitea#27870)
  refactor postgres connection string building (go-gitea#27723)
  doc: actions/act-runner: document running as a systemd service (go-gitea#27844)
  Support storage base path as prefix (go-gitea#27827)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…tea#27844)

This documents running `act-runner` as a systemd service under a
dedicated user account.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants