Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapping to long diff lines #2789

Merged
merged 4 commits into from
Oct 27, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Oct 26, 2017

Just reopening #1954 as new PR. After unsuccessful rebase&push I can no longer push to @mjwwit branch :(

Fixes #1827

@lafriks lafriks added this to the 1.3.0 milestone Oct 26, 2017
@lafriks
Copy link
Member Author

lafriks commented Oct 26, 2017

Giving back my LGTM from original PR

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 26, 2017
@lafriks lafriks added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Oct 26, 2017
@codecov-io
Copy link

Codecov Report

Merging #2789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2789   +/-   ##
======================================
  Coverage    27.2%   27.2%           
======================================
  Files          88      88           
  Lines       17374   17374           
======================================
  Hits         4726    4726           
  Misses      11962   11962           
  Partials      686     686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb7f59...8dea230. Read the comment docs.

@lunny
Copy link
Member

lunny commented Oct 27, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2017
@lunny lunny merged commit 762f1d7 into go-gitea:master Oct 27, 2017
vdbt pushed a commit to vdbt/gitea that referenced this pull request Oct 27, 2017
* Add wrapping to long diff lines to fix go-gitea#1827

* Fix  css class and make changes to source (less) files

* Fix wrong space indentation

* Fix indentation inconsistencies and remove very old WebKit workaround
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 1, 2019
Wrapping was initially added in go-gitea#2789
but it is currently disabled because the rule that applies wrapping to
the wrap class did not have enough CSS specificity.

Resolved the issue by using a general selector that matches all code
boxes. The previous wrap class was removed because it had only been
inconsistenly applied to various code boxes and because I found no easy
way to add classes to code boxes rendered in Markdown.

Also removed a seemingly useless :before on code view and added padding
to restore the spacing.
zeripath pushed a commit that referenced this pull request Feb 2, 2019
Wrapping was initially added in #2789
but it is currently disabled because the rule that applies wrapping to
the wrap class did not have enough CSS specificity.

Resolved the issue by using a general selector that matches all code
boxes. The previous wrap class was removed because it had only been
inconsistenly applied to various code boxes and because I found no easy
way to add classes to code boxes rendered in Markdown.

Also removed a seemingly useless :before on code view and added padding
to restore the spacing.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapping long lines in code views
5 participants