Refactoring packages error processing #27979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
modifies/api
KN4CK3R
reviewed
Nov 9, 2023
services/packages/packages.go
Outdated
Comment on lines
29
to
31
| ErrQuotaTypeSize = util.NewInvalidArgumentErrorf("maximum allowed package type size exceeded") | ||
| ErrQuotaTotalSize = util.NewInvalidArgumentErrorf("maximum allowed package storage quota exceeded") | ||
| ErrQuotaTotalCount = util.NewInvalidArgumentErrorf("maximum allowed package count exceeded") |
There was a problem hiding this comment.
Is "you have reached a limit" an "argument error"?
There was a problem hiding this comment.
No. Added draft with FailedPrecondition (similar with gRPC spec) error in this branch. Would it be valid for current scenario?
There was a problem hiding this comment.
Is it a mistake that only ErrQuotaTotalCount is a util.NewFailedPreconditionErrorf?
ghost
mentioned this pull request
pull-request-size
bot
added
size/XXL
ghost
changed the title
ghost
changed the title
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
|
I added some corrections and simplifactions to enhance the error handling process.
I am not sure about this implementation or whether this approach might be applicable. This model might be useful because different internal error changes will be handled automatically, potentially reducing the number of accidental errors, but it requires additional attention to error messages since those messages might be passed to the client side. |
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifyed approach to form response codes from gitea errors in packages module.